New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow-cpp: fix build by using internal gtest #52928
Conversation
1f6b095 has switched gtest to split shared build, but arrow-cpp assumes that headers are near the static libraries.
Should not the |
Hmm, even if I remove the split outputs,
I have just recently fixed the same issue in openjpeg but they do not use generated export files like gtest does. |
I have just noticed that now |
I tried patching gtest and it now produces correct config files but the correct version is still not used, I am not sure where does the gtest 1.8.0 come from https://github.com/jtojnar/nixpkgs/pull/new/gtest |
I don't know the exact origin of 1.8.0, but when |
Using vendored builds will requires network access during the build and that's not allowed in restricted build on Hydra. You could try to implement download using |
Motivation for this change
1f6b095 has switched gtest to split shared build, but arrow-cpp assumes that headers are near the static libraries.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)