Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some gnome libs to toplevel #52879

Merged
merged 7 commits into from Dec 26, 2018
Merged

Move some gnome libs to toplevel #52879

merged 7 commits into from Dec 26, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) labels Dec 25, 2018
@worldofpeace worldofpeace force-pushed the move-gnome-libs-toplevel branch 4 times, most recently from 890104e to 2041712 Compare December 26, 2018 00:50
@worldofpeace
Copy link
Contributor Author

worldofpeace commented Dec 26, 2018 •
edited

Ok this eval fail is now from hackage-packages.nix with a reference to gnome3.vte.
I'm not familiar with haskell in nixpkgs but I know that this file is autogenerated.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2018 •
edited

It is probably a good idea to inherit the libraries inside gnome3 attrset, not only for the haskell but also so we could still update them with nix-shell maintainers/scripts/update.nix --argstr path gnome3 (until we implement package tags).

@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2018

Thank you.

@jtojnar jtojnar merged commit e5271b7 into NixOS:staging Dec 26, 2018
@worldofpeace worldofpeace deleted the move-gnome-libs-toplevel branch December 26, 2018 02:38
@worldofpeace
Copy link
Contributor Author

Always happy to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg