Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin: 0.17.0 -> 0.17.1 #52868

Merged
merged 1 commit into from Jan 5, 2019
Merged

Bitcoin: 0.17.0 -> 0.17.1 #52868

merged 1 commit into from Jan 5, 2019

Conversation

roconnor
Copy link
Contributor

Motivation for this change

Updating to latest Bitcoin release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Verified that the source code's SHA256 hash is signed by "Wladimir J. van der Laan (Bitcoin Core binary release signing key) laanwj@gmail.com" Primary key fingerprint: 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964.

@jb55 Would you like to review?

@jonasnick
Copy link
Contributor

works for me

@jonasnick
Copy link
Contributor

Also, the sha256 matches what is signed by the Bitcoin Core maintainer.

@roconnor roconnor merged commit 9ff125c into NixOS:master Jan 5, 2019
@roconnor roconnor deleted the bitcoin branch January 5, 2019 20:15
@prusnak
Copy link
Member

prusnak commented Jan 7, 2019

What is the general consensus about pushing version updates (via cherry-picking) to released versions (such as release-18.09)?

@jonasnick jonasnick mentioned this pull request May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roconnor @jonasnick @prusnak @GrahamcOfBorg