Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages_4_{19,20}: works around bug with overlayfs #52942

Merged
merged 1 commit into from Dec 26, 2018

Conversation

samueldr
Copy link
Member

See: #48828 (comment)

I ran the following:

env -i nix-build nixos/release.nix -A tests.boot-stage1.x86_64-linux

Both with linuxPackages set to 4_19 (current default) and 4_20 (to make sure the other change is good).

The patch is literally the one from @aszlig's comment in the linked thread, but applied as a commit on top of the linux repository; only to get it as a fetchpatch-able artifact. Though I do encourage you to load up and verify the patch.

There is no upstream issue opened yet. I don't think I'm able to work with upstream as I don't really know the details of the issue. @aszlig maybe will handle that.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ⬜ macOS
    • ⬜ other Linux distributions
  • ✔️ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • ⬜ Tested execution of all binary files (usually in ./result/bin/)
  • ✔️ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Assured whether relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

cc @domenkozar

@domenkozar
Copy link
Member

@GrahamcOfBorg test boot-stage1.x86_64-linux

@domenkozar
Copy link
Member

@GrahamcOfBorg test boot-stage1

@samueldr
Copy link
Member Author

@GrahamcOfBorg build nixosTests.boot-stage1

(I was searching whether this was fixed or not; the issue with running tests.)

@samueldr
Copy link
Member Author

The x86_64 build timed out, the aarch64 build succeeded. Locally, here, I have verified the x86_64 build.

@domenkozar domenkozar merged commit 889ef35 into NixOS:master Dec 26, 2018
@samueldr samueldr deleted the fix/4.19-overlayfs-issues branch February 12, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants