Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmfd: init at 1.1.3 #52948

Closed
wants to merge 2 commits into from
Closed

nmfd: init at 1.1.3 #52948

wants to merge 2 commits into from

Conversation

Ameliorate
Copy link

Motivation for this change

nmfd is a simple helper program that watches the status of the side buttons on a Razer Naga mouse and prints the keypress events to stdout, allowing the easy creation of macro scripts.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested fixes made. Binary runs, Can't really test without the mouse, but new maintainer added to list. @Ameliorate Thanks for the PR!

man pages work.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

preBuild = ''
mkdir -p $out/bin
mkdir -p $out/share/man/man1
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

''; is not aligned properly

homepage = https://github.com/Ameliorate/nmfd;
license = licenses.mit;
maintainers = [ maintainers.amelorate ];
platforms = platforms.all;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
platforms = platforms.all;
platforms = platforms.linux;

Looks like this would only be useful for those platforms.

sha256 = "1gk3kz9m8547yn9w7cr4a3nlg5pq7z86mksv2ayrmvcicm6m0ifc";
};

makeFlags = [ "INSTALL_PATH=$(out)/bin/" "MANUAL_PATH=$(out)/share/man/man1" ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
makeFlags = [ "INSTALL_PATH=$(out)/bin/" "MANUAL_PATH=$(out)/share/man/man1" ];
makeFlags = [ "INSTALL_PATH=${placeholder ''out''}/bin/" "MANUAL_PATH=${placeholder ''out''}/share/man/man1" ];


stdenv.mkDerivation rec {
pname = "nmfd";
version = "1.1.3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "1.1.3";
version = "1.1.3";

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the minor comments above.

Additonally it's preferred to add yourself to the maintainers list in a separate commit like

maintainers: add amelorate

Or any other common variation you see in the git history.

(also rebase to latest master)

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

@Ameliorate are you able to address the above comments and continue with this PR?

@Ameliorate
Copy link
Author

Oh right this. I've actually gotten rid of my naga mouse since writing this package. Since I don't have any way to test nmfd, I'll just close this PR.

@Ameliorate Ameliorate closed this Aug 11, 2019
@aanderse
Copy link
Member

Thanks for follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants