New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmfd: init at 1.1.3 #52948
nmfd: init at 1.1.3 #52948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested fixes made. Binary runs, Can't really test without the mouse, but new maintainer added to list. @Ameliorate Thanks for the PR!
man pages work.
This pull request has been mentioned on Nix community. There might be relevant details there: |
preBuild = '' | ||
mkdir -p $out/bin | ||
mkdir -p $out/share/man/man1 | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'';
is not aligned properly
homepage = https://github.com/Ameliorate/nmfd; | ||
license = licenses.mit; | ||
maintainers = [ maintainers.amelorate ]; | ||
platforms = platforms.all; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platforms = platforms.all; | |
platforms = platforms.linux; |
Looks like this would only be useful for those platforms.
sha256 = "1gk3kz9m8547yn9w7cr4a3nlg5pq7z86mksv2ayrmvcicm6m0ifc"; | ||
}; | ||
|
||
makeFlags = [ "INSTALL_PATH=$(out)/bin/" "MANUAL_PATH=$(out)/share/man/man1" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makeFlags = [ "INSTALL_PATH=$(out)/bin/" "MANUAL_PATH=$(out)/share/man/man1" ]; | |
makeFlags = [ "INSTALL_PATH=${placeholder ''out''}/bin/" "MANUAL_PATH=${placeholder ''out''}/share/man/man1" ]; |
|
||
stdenv.mkDerivation rec { | ||
pname = "nmfd"; | ||
version = "1.1.3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version = "1.1.3"; | |
version = "1.1.3"; | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the minor comments above.
Additonally it's preferred to add yourself to the maintainers list in a separate commit like
maintainers: add amelorate
Or any other common variation you see in the git history.
(also rebase to latest master)
@Ameliorate are you able to address the above comments and continue with this PR? |
Oh right this. I've actually gotten rid of my naga mouse since writing this package. Since I don't have any way to test nmfd, I'll just close this PR. |
Thanks for follow-up! |
Motivation for this change
nmfd is a simple helper program that watches the status of the side buttons on a Razer Naga mouse and prints the keypress events to stdout, allowing the easy creation of macro scripts.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)