Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python36,python37: fix darwin build #52941

Merged
merged 2 commits into from Dec 27, 2018
Merged

python36,python37: fix darwin build #52941

merged 2 commits into from Dec 27, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 26, 2018 •
edited

Motivation for this change

Python 3.6

Python3.7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner December 26, 2018 20:42
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Dec 26, 2018
@marsam marsam mentioned this pull request Dec 26, 2018
Closed
@veprbl
Copy link
Member

veprbl commented Dec 27, 2018

Thank you! Could you, please, also publish the updated patches on the python bug tracker? We could then fetchpatch them back...

@marsam
Copy link
Contributor Author

marsam commented Dec 27, 2018

sure, updated

@marsam
python36: fix darwin build
3a854f3 
Remove issue24658 patch because is already fixed and backported to
Python 3.6 python/cpython@a5ebc20
@marsam
python37: fix darwin build
7006515 
Remove issue24658 patch because is already fixed and backported to
Python 3.7 python/cpython@178d1c0
@FRidh FRidh merged commit 1764870 into NixOS:master Dec 27, 2018
@marsam marsam deleted the fix-python-darwin branch December 27, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @veprbl @FRidh @GrahamcOfBorg