New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos vdr: introduce option enableLirc #52943
Conversation
also introduce option socket for lirc, to have access to socket path
@Mic92 could you please have a look. |
@@ -49,8 +56,7 @@ in { | |||
description = "LIRC daemon socket"; | |||
wantedBy = [ "sockets.target" ]; | |||
socketConfig = { | |||
# default search path | |||
ListenStream = "/run/lirc/lircd"; | |||
ListenStream = cfg.socket; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we really need this option, I would rather hard-code it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I need that option to allow other modules like the vdr module to have access to the socket path. That option gives clear dependencies between two modules.
@@ -43,14 +42,15 @@ in { | |||
# Note: LIRC executables raises a warning, if lirc_options.conf do not exists | |||
environment.etc."lirc/lirc_options.conf".text = cfg.options; | |||
|
|||
passthru.lirc.socket = "/run/lirc/lircd"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution. I tested your changes and works fine.
also introduce option socket for lirc, to have access to socket path
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)