Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nox-review from pull request template #52935

Closed
wants to merge 1 commit into from
Closed

remove nox-review from pull request template #52935

wants to merge 1 commit into from

Conversation

stephengroat
Copy link
Contributor

Motivation for this change

doesn't seem to work in docker image or on mac on latest build, plus a reference was made that it is unmaintained (#52524 (comment))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2018

Yeah, @Mic92’s nix-review is supposed to replace it.

@stephengroat
Copy link
Contributor Author

stephengroat commented Dec 26, 2018 •
edited

Yeah, @Mic92’s nix-review is supposed to replace it.

any idea on the status of nix-review? i was also have problems getting that running. i have plenty of cores to throw at an issue, just couldn't get nix-review to run (again, mainly in docker and on mac). see #52524 (comment)

@jtojnar
Copy link
Contributor

jtojnar commented Dec 26, 2018

nix-review is actively developed, so I suggest you try to open an issue in its repo or try to connect with its author on IRC.

@timokau
Copy link
Member

timokau commented Dec 29, 2018

So should we just replace nox-review with nix-review in the PR template?

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

ping

@stephengroat
Copy link
Contributor Author

closed because already addressed

@stephengroat stephengroat deleted the patch-3 branch August 5, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: policy discussion 9.needs: community feedback 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stephengroat @jtojnar @timokau @aanderse @FRidh @GrahamcOfBorg