Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyro #52936

Merged
merged 2 commits into from Dec 31, 2018
Merged

Pyro #52936

merged 2 commits into from Dec 31, 2018

Conversation

teh
Copy link
Contributor

@teh teh commented Dec 26, 2018

Motivation for this change

Introduce pyro (probabilistic programming language based on pytorch) + one dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teh teh requested a review from FRidh as a code owner December 26, 2018 18:34
FRidh
FRidh reviewed Dec 26, 2018
View reviewed changes
pkgs/development/python-modules/opt-einsum/default.nix Outdated
description = "Optimizing NumPy's einsum function with order optimization and GPU support.";
homepage = http://optimized-einsum.readthedocs.io;
license = lib.licenses.mit;
platforms = lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why modify platforms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason other than copy-paste. Removed.

pkgs/development/python-modules/pyro-ppl/default.nix Outdated
description = "A Python library for probabilistic modeling and inference";
homepage = http://pyro.ai;
license = lib.licenses.mit;
platforms = lib.platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why modify platforms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's the same as pytorch but I guess that's implicit in the dependency. Removed.

@teh
Copy link
Contributor Author

teh commented Dec 27, 2018

@GrahamcOfBorg build python2Packages.pyro-ppl python3Packages.pyro-ppl

@infinisil infinisil merged commit a02b6bc into NixOS:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teh @FRidh @infinisil @GrahamcOfBorg