Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sway-beta: 1.0-beta.2 -> 1.0-rc1 #55117

Merged
merged 3 commits into from Feb 3, 2019
Merged

sway-beta: 1.0-beta.2 -> 1.0-rc1 #55117

merged 3 commits into from Feb 3, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 3, 2019

Motivation for this change

Will be released in ~3h and since a few things changed I decided to test it in advance.

cc @gnidorah @colemickens @Synthetica FYI and in case I missed something

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -60,10 +60,11 @@ in {
extraPackages = mkOption {
type = with types; listOf package;
default = with pkgs; [
swaylock swayidle
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably still (temporarily) break a few setups as it obviously doesn't apply if extraPackages was overridden but IMO it's still the best option (e.g. compared to forcing these packages, introducing additional options, ...). We could print a warning if they're missing but that would be annoying for users who use other packages. And since it's a beta module I don't think this is a big problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this is the only correct way to do it, as they are independent executables that do not depend on each other (since sway v1.0).

@timokau
Copy link
Member

timokau commented Feb 3, 2019

It has been released now 🎉

What is the current status of sway on nixos? I remember that there is an overlay for sway? Is that needed? Could I run the rc as a daily driver?

@primeos primeos changed the title [WIP] sway-beta: 1.0-beta.2 -> 1.0-rc1 sway-beta: 1.0-beta.2 -> 1.0-rc1 Feb 3, 2019
@primeos
Copy link
Member Author

primeos commented Feb 3, 2019

What is the current status of sway on nixos?

We have two modules for sway (0.x) and sway-beta (1.x), both should be usable (personally, I prefer sway-beta).

I remember that there is an overlay for sway? Is that needed?

Only if you want to have the most recent version and a few extra packages for Wayland that aren't in nixpkgs yet (AFAIK/IIRC).

Could I run the rc as a daily driver?

Not sure, I didn't have any problems so far (no crashes or major bugs) but that probably depends on your hardware and applications. I assume it isn't as stable as i3 ATM (still use that on my laptop with very high uptimes) but it seems very promising so far :)

@primeos primeos merged commit 07b70bd into NixOS:master Feb 3, 2019
@timokau
Copy link
Member

timokau commented Feb 3, 2019

Alright, thank you for the summary! Excited to see this mature.

@ghost
Copy link

ghost commented Feb 3, 2019

@primeos Awesome! Thanks for casting

@colemickens
Copy link
Member

Only if you want to have the most recent version and a few extra packages for Wayland that aren't in nixpkgs yet (AFAIK/IIRC).

Yeah, this is spot on - https://github.com/colemickens/nixpkgs-wayland - the README example snippet includes some one-liner descriptions of the additional packages included as well, though they're increasingly having stable releases and are appearing in nixpkgs thanks to @primeos etc. Overtime the overlay will probably just be used by people wanting to run HEAD builds.

(Also, I use Sway as a daily driver. It's mostly okay, I'm willing to make compromises to get Wayland+mixed DPI support)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants