Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in closest town calculation with threshold #7166

Closed
GabdaZM opened this issue Feb 3, 2019 · 1 comment
Closed

Inconsistency in closest town calculation with threshold #7166

GabdaZM opened this issue Feb 3, 2019 · 1 comment

Comments

@GabdaZM
Copy link
Contributor

GabdaZM commented Feb 3, 2019

In CalcClosestTownFromTile if the distance of the tile and closest town is equal with the threshold, the function returns with NULL.
In ClosestTownFromTile, roads with the distance of threshold from the town are still return with the town, and not NULL.

So if a tile is threshold away from a town, ClosestTownFromTile will return with the town if there is a road, but NULL otherwise (if it calls CalcClosestTownFromTile). With the distance of threshold + 1, both cases return with NULL.

@LordAro LordAro changed the title Incosistency in closest town calculation with threshold Inconsistency in closest town calculation with threshold Feb 4, 2019
@GabdaZM
Copy link
Contributor Author

GabdaZM commented Feb 8, 2019

My bad, it is good.

@GabdaZM GabdaZM closed this as completed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant