Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus: use append instead of insert for opening firewalls #55224

Merged
merged 1 commit into from Mar 13, 2019

Conversation

thefloweringash
Copy link
Member

Inserting with -I causes the rules to placed before ctstate
tracking, while -A places them alongside all other allow rules.

Motivation for this change

Before

Chain nixos-fw (1 references)
 pkts bytes target     prot opt in     out     source               destination
    0     0 nixos-fw-accept  tcp  --  *      *       0.0.0.0/0            0.0.0.0/0            tcp dpt:9100 /* node-exporter */
3832K  749M nixos-fw-accept  all  --  lo     *       0.0.0.0/0            0.0.0.0/0
1066K 4080M nixos-fw-accept  all  --  *      *       0.0.0.0/0            0.0.0.0/0            ctstate RELATED,ESTABLISHED
    1    64 nixos-fw-accept  tcp  --  *      *       0.0.0.0/0            0.0.0.0/0            tcp dpt:22
    0     0 nixos-fw-accept  icmp --  *      *       0.0.0.0/0            0.0.0.0/0            icmptype 8
 110K   29M nixos-fw-log-refuse  all  --  *      *       0.0.0.0/0            0.0.0.0/0

After

Chain nixos-fw (1 references)
 pkts bytes target     prot opt in     out     source               destination
  414 75214 nixos-fw-accept  all  --  lo     *       0.0.0.0/0            0.0.0.0/0
   36  7770 nixos-fw-accept  all  --  *      *       0.0.0.0/0            0.0.0.0/0            ctstate RELATED,ESTABLISHED
    0     0 nixos-fw-accept  tcp  --  *      *       0.0.0.0/0            0.0.0.0/0            tcp dpt:22
    0     0 nixos-fw-accept  icmp --  *      *       0.0.0.0/0            0.0.0.0/0            icmptype 8
    0     0 nixos-fw-accept  tcp  --  *      *       0.0.0.0/0            0.0.0.0/0            tcp dpt:9100 /* node-exporter */
    7  1621 nixos-fw-log-refuse  all  --  *      *       0.0.0.0/0            0.0.0.0/0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Inserting with `-I` causes the rules to placed before `ctstate`
tracking, while `-A` places them alongside all other allow rules.
@danbst
Copy link
Contributor

danbst commented Mar 13, 2019

@WilliButz what do you think about this?

Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefloweringash thank you 👍

@danbst danbst merged commit c53703a into NixOS:master Mar 13, 2019
@thefloweringash thefloweringash deleted the prometheus-firewall branch May 1, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants