Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: use matching nginx package when configuring nginx #55222

Merged
merged 1 commit into from Feb 4, 2019
Merged

nixos/nextcloud: use matching nginx package when configuring nginx #55222

merged 1 commit into from Feb 4, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

NixOS currently defaults services.nginx.package to
nginxStable. Including configuration files from nginxMainline could
potentially cause incompatible configuration.

Also should reduce closure size, as a typical system will no longer depend on two versions of nginx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash
nixos/nextcloud: use matching nginx package when configuring nginx
a7d9dca 
NixOS currently defaults services.nginx.package to
nginxStable. Including configuration files from nginxMainline could
potentially cause incompatible configuration.
@infinisil
Copy link
Member

@GrahamcOfBorg test nextcloud

@Ma27 Ma27 merged commit ae7e8c6 into NixOS:master Feb 4, 2019
@thefloweringash thefloweringash deleted the nextcloud-nginx-config branch May 1, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @infinisil @Ma27 @GrahamcOfBorg