Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifdtool: init at 4.9 #55066

Merged
merged 1 commit into from Feb 2, 2019
Merged

ifdtool: init at 4.9 #55066

merged 1 commit into from Feb 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2019 •
edited by ghost

Motivation for this change
Things done

ifdtool: init at 4.9

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 2, 2019

@GrahamcOfBorg build ifdtool

flokli
flokli requested changes Feb 2, 2019
View reviewed changes
pkgs/tools/misc/ifdtool/default.nix Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Feb 2, 2019

@GrahamcOfBorg build ifdtool

@ghost
Copy link
Author

ghost commented Feb 2, 2019

The last push changed the source to download a release tarball instead of fetching a git repository, which is faster.

@flokli
Copy link
Contributor

flokli commented Feb 2, 2019

@GrahamcOfBorg build ifdtool

@flokli flokli merged commit a9bf045 into NixOS:master Feb 2, 2019
flokli added a commit to flokli/nixpkgs that referenced this pull request Feb 2, 2019
@flokli
cbfstool: 4.7 -> 4.9
bb49dca 
also fix source, followup of NixOS#55066
@flokli flokli mentioned this pull request Feb 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @GrahamcOfBorg