Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trilium: 0.27.4 -> 0.28.3 #55069

Merged
merged 2 commits into from Feb 7, 2019
Merged

trilium: 0.27.4 -> 0.28.3 #55069

merged 2 commits into from Feb 7, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 2, 2019

  • Fetch svg icon since no longer included.
  • Move to xz so don't need p7zip
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
trilium: 0.27.4 -> 0.28.3
ee124b7 
* Fetch svg icon since no longer included.
* Move to xz so don't need p7zip
@worldofpeace
Copy link
Contributor

Execution dies with this message on my machine

./result/bin/trilium: error while loading shared libraries: libffmpeg.so: cannot open shared object file: No such file or directory

@dtzWill
Copy link
Member Author

dtzWill commented Feb 2, 2019

Execution dies with this message on my machine

Strange!

  1. Does it work if you install it into your profile? Just a thought.
  2. Since we create a wrapper that sets LD_LIBRARY_PATH, maybe that's interacting badly with whichever of RPATH or RUNPATH is being set in the autoPatchELF'ing. A possible fix that doesn't require diving into that too deeply ;) is to try something like this: dtzWill@d0ebf34 . Maybe that'll do the trick?
  3. The libraries in $out/share/trilium don't have rpath/runpath set for the libraries they need, which maybe they should.
  4. Does trilium run for you with any version (before this PR, for example)?

@dtzWill
Copy link
Member Author

dtzWill commented Feb 5, 2019

Ping :). Or can someone else see if it runs for them? Thanks!

@srhb
Copy link
Contributor

srhb commented Feb 7, 2019

Runs for me in a nix-shell / using nix run!

@dtzWill
Copy link
Member Author

dtzWill commented Feb 7, 2019

Thanks!

@dtzWill dtzWill merged commit 9405b52 into NixOS:master Feb 7, 2019
@dtzWill dtzWill deleted the update/trilium-0.28.3 branch February 7, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @worldofpeace @srhb @GrahamcOfBorg