Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lkl: install liblkl.so and liblkl-hijack.so #55070

Merged
merged 1 commit into from Feb 4, 2019
Merged

lkl: install liblkl.so and liblkl-hijack.so #55070

merged 1 commit into from Feb 4, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

The lkl package currently does not contain liblkl-hijack.so, which prevents the lkl-hijack.sh script from working. I also noticed that liblkl.so is not being installed. It appears that the locations of the libraries in the source tree changed since a previous version.

Things done

Install all the necessary libraries.

cc @copumpkin

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 6e8ce99 into NixOS:master Feb 4, 2019
@teto
Copy link
Member

teto commented Feb 12, 2019

Would be nice if it could reuse the kernel building machinery (to allow overriding the config etc).

I had added test support here
teto@57cafb9

and in another commit, I was generating the .pc files (for pkg-config) but not sure where, I can look for it if there is interest

@joachifm
Copy link
Contributor

@teto both of those sound good to me

@teto
Copy link
Member

teto commented Feb 13, 2019

(I found the one with pkg-config additions https://github.com/teto/home/blob/master/nixpkgs/overlays/pkgs/lkl.nix ) though I haven't tested it much so don't feel like upstreaming.

@lopsided98 lopsided98 deleted the lkl-hijack-fix branch February 15, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @teto @joachifm @GrahamcOfBorg