Add: [AzurePipelines] split the CI in two parts: building and commit checking #7163
Conversation
…checking This makes it a bit more clear to the user what went wrong; instead of "everything", you can now see if either the building failed, or that the commit checker failed. Also, this means the commit checker reports back earlier, which might help in the workflow.
TrueBrain
force-pushed
the
split_checker
branch
from
da87a13
to
cc560f4
Compare
|
Click on "Show all checks" to get an idea of how this works |
|
Does this fix the issues with Docker message spew when the commit checker fails? If not, would it be an idea to not use a Docker image for this, but rather run in the raw environment provided by Azure? It should not be a problem regarding build tool or library versions for this purpose. |
|
The Docker image thing has an issue here: OpenTTD/CompileFarm#18 For the commit-checker we could do without the Docker, yes. But it might be better that we fix the Docker issue, as otherwise the Linux builds still have the issue. Not sure what is better to spend our time on. The Docker issue really is just someone looking into it to solve it. Like mentioned in the issue, an extra 'docker pull' or something could already resolve it. This PR exists because we were wondering if it would help if we report both instances separately, to give faster insight what part failed. Looking at the Azure Pipelines changelog, it seems they are even working towards showing each Job separate. But as that version is not live yet, I am not sure what exactly they changed regarding this (https://docs.microsoft.com/en-us/azure/devops/release-notes/2019/sprint-146-update#display-status-for-each-pipeline-job-in-github-checks). So I guess your request can be a follow-up on this one. I do not want to make it part of this PR, as I rather would like to know if we want one or multiple builds. Personally I am +0. Come to think of it, it might be better to wait for the above mentioned change being live. So I am going to close this for now. |
|
The update is live it seems, and the result looks nice. |
This makes it a bit more clear to the user what went wrong; instead
of "everything", you can now see if either the building failed, or
that the commit checker failed.
Also, this means the commit checker reports back earlier, which
might help in the workflow.