Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sly: init at 0.3 #55093

Merged
merged 1 commit into from Feb 7, 2019
Merged

python3Packages.sly: init at 0.3 #55093

merged 1 commit into from Feb 7, 2019

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Feb 2, 2019

tests will be included with the next release
dabeaz/sly#25
this is why I have not disabled tests (currently they pass with 0
tests run).

Motivation for this change

Saw a great talk on this package. Looking to toy around with an LALR parser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner February 2, 2019 18:17
dotlambda
dotlambda requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why I have not disabled tests

Even when using fetchFromGitHub, no tests are run. Hence, a checkPhase will have to be added once they are published on PyPI and should be disabled for now.

pkgs/development/python-modules/sly/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/sly/default.nix Outdated Show resolved Hide resolved
@costrouc
Copy link
Member Author

costrouc commented Feb 3, 2019

@GrahamcOfBorg build python3Packages.sly

@dotlambda
Copy link
Member

this is why I have not disabled tests

Even when using fetchFromGitHub, no tests are run. Hence, a checkPhase will have to be added once they are published on PyPI and should be disabled for now.

This has not been addressed.

@costrouc
Copy link
Member Author

costrouc commented Feb 3, 2019 •
edited

@dotlambda it is not using fetchFromGitHub it is using fetchPyPi thus on the next release it will be "fixed" and actual tests will run. Are we going to remember when @r-ryantm autoupdates this package to set the checkPhase = true? I don't see any harm in this release running tests and passing with 0 tests run. Maybe I am misunderstanding?

@dotlambda
Copy link
Member

You are. I tested this by using fetchFromGitHub and it turned out no tests were run without setting an appropriate checkPhase.

@costrouc
python3Packages.sly: init at 0.3
93f02e6 
tests will be included with the next release
dabeaz/sly#25
this is why I have not disabled tests (currently they pass with 0
tests run).
@costrouc
Copy link
Member Author

costrouc commented Feb 7, 2019

@dotlambda I have disabled tests via doCheck = false;. Should be ready for merge

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3Packages.sly

@dotlambda dotlambda merged commit e16e9c9 into NixOS:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @dotlambda @GrahamcOfBorg