Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgconfig: rename to pkg-config #55094

Merged
merged 1 commit into from Feb 3, 2019
Merged

pkgconfig: rename to pkg-config #55094

merged 1 commit into from Feb 3, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 2, 2019

Package attrs should map to the pname. It's confusing otherwise.

pkg-config is also the name used by most distributions:

Debian, Homebrew, Guix, OpenSuse

other distributions like FreeBSD ports, Fedora and Arch Linux call it
"pkgconf"

Waiting a few releases to make a tree-wide change to make it easier to
back-port things.

Motivation for this change

I keep typing pkg-config all the time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Looks good! This might be one to not put in aliases.nix for a while since it is almost everywhere.

@zimbatm
pkgconfig: rename to pkg-config
bff5405 
Package attrs should map to the pname. It's confusing otherwise.

pkg-config is also the name used by most distributions:

Debian, Homebrew, Guix, OpenSuse

other distributions like FreeBSD ports, Fedora and Arch Linux call it
"pkgconf"

Waiting a few releases to make a tree-wide change to make it easier to
back-port things.
@zimbatm
Copy link
Member Author

zimbatm commented Feb 2, 2019

Ok, glad to see that I am not alone :) There are more packages that don't map 1:1 with their pname by the way.

I think you are right, since pkg-config is used in the bootstrap, evaluation fails if it's in in the aliases.nix.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 2, 2019

Hmm, repology displays the same name for nixpkgs: https://repology.org/metapackage/pkg-config/versions

Also a side note: pkgconf is a competing project that implements pkg-config command for compatibility.

@vcunat
Copy link
Member

vcunat commented Feb 2, 2019 •
edited

👍 for alias, one way or another. I think adding aliases is safe even for the stable branch, easing backports. I'm not really certain a mass replace is worth it, but this PR isn't really about that.

@vcunat
Copy link
Member

vcunat commented Feb 2, 2019

Repology displays the "name" attribute, not the attribute name, so that's already "pkg-config". (uh, how would I better formulate that :)

@zimbatm
Copy link
Member Author

zimbatm commented Feb 3, 2019

Evaluation fails if I move it into aliases.nix, probably because it's an input for the stdenv and aliases.nix only comes after the stdenv bootstrap.

@zimbatm zimbatm merged commit abac6af into NixOS:master Feb 3, 2019
@zimbatm zimbatm deleted the rename-pkg-config branch February 3, 2019 15:35
@yvt yvt mentioned this pull request Oct 7, 2022
Merged
5 tasks
bors-servo added a commit to servo/servo that referenced this pull request Oct 9, 2022
@bors-servo
Auto merge of #29007 - yvt:patch/nix-pkgconfig, r=jdm
543fc51 
`etc/shell.nix`: Replace `pkgconfig` with `pkg-config`

`pkgconfig` is [an old name][1] of `pkg-config` that has been [completely removed][2] in a recent version of nixpkgs.

[1]: NixOS/nixpkgs#55094
[2]: NixOS/nixpkgs#192681

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

---
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they don't affect the production code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@andir andir Awaiting requested review from andir

@lovek323 lovek323 Awaiting requested review from lovek323

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zimbatm @matthewbauer @jtojnar @vcunat @GrahamcOfBorg