Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbfstool: 4.7 -> 4.9 #55099

Merged
merged 1 commit into from Feb 2, 2019
Merged

cbfstool: 4.7 -> 4.9 #55099

merged 1 commit into from Feb 2, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 2, 2019

also fix source, followup of #55066

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
cbfstool: 4.7 -> 4.9
bb49dca 
also fix source, followup of NixOS#55066
@flokli flokli requested a review from fpletz February 2, 2019 22:33
@fpletz fpletz merged commit d72bada into NixOS:master Feb 2, 2019
@flokli flokli deleted the cbfstool-3.9 branch February 2, 2019 23:07
@fpletz fpletz mentioned this pull request Feb 3, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @fpletz @GrahamcOfBorg