Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boehmgc{,_766}: add space before appending to CFLAGS (only done w/musl) #55133

Merged
merged 2 commits into from Feb 12, 2019
Merged

boehmgc{,_766}: add space before appending to CFLAGS (only done w/musl) #55133

merged 2 commits into from Feb 12, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 3, 2019

Motivation for this change

Otherwise we risk creating a rather strange argument!

This was preventing boehmgc from finding libatomic_ops on 32bit arch
(pkgsCross.muslpi.boehmgc)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 3, 2019

@GrahamcOfBorg build pkgsMusl.boehmgc pkgsCross.muslpi.boehmgc

@dtzWill dtzWill mentioned this pull request Feb 3, 2019
Merged
10 tasks
@dtzWill dtzWill merged commit 92a54bd into NixOS:master Feb 12, 2019
@dtzWill dtzWill deleted the fix/bdwgc-musl-cflags-space branch February 12, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @ivmai @GrahamcOfBorg