Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steam: provide pidof and lsusb for Steam VR #55136

Merged
merged 1 commit into from May 20, 2019
Merged

steam: provide pidof and lsusb for Steam VR #55136

merged 1 commit into from May 20, 2019

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Feb 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@corngood
Copy link
Contributor Author

corngood commented Feb 3, 2019

Without this, Steam VR would fail to start with an 'HMD not found' message box. The output contained lots of errors about missing lsusb and pidof. I was also getting the error described in #40209, but I'm not sure if this is a complete fix for that issue.

@Lassulus
Copy link
Member

Tested it with nix-review, everything seems to run as expected. I don't have VR equipment thought, to test it.

@Lassulus Lassulus merged commit 9d8c27e into NixOS:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @Lassulus @GrahamcOfBorg