Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite sorting issue with FIRS #7136

Closed
George-VB opened this issue Jan 29, 2019 · 6 comments
Closed

Sprite sorting issue with FIRS #7136

George-VB opened this issue Jan 29, 2019 · 6 comments
Labels
regression It used to work, and now it's broken.
Milestone

Comments

@George-VB
Copy link

image

@LordAro
Copy link
Member

LordAro commented Jan 29, 2019

It's very unclear from this (even with the nice red box) what's wrong with this image and what it is supposed to look like. Can you elaborate?

@PeterN
Copy link
Member

PeterN commented Jan 29, 2019

This is likely related to #7133, as both involve child ground sprites.

@PeterN
Copy link
Member

PeterN commented Jan 29, 2019

@George-VB, in your bug report please elaborate on what the issue is. You should write down what you expected to happen, and what behaviour happens instead. Just a single picture is not really enough. You should also include steps to reproduce this issue. That is standard bug-reporting etiquette!

@George-VB
Copy link
Author

I expect ground tiles to be drawn "behind" objects on them
image

@PeterN
Copy link
Member

PeterN commented Jan 31, 2019

Thanks @George-VB. I have now play tested another NewGRF and in that case the images are flickering as well. Definitely a sprite-sorter issue.

@PeterN PeterN added this to the 1.9.0 milestone Feb 1, 2019
@PeterN PeterN added the regression It used to work, and now it's broken. label Feb 1, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 3, 2019
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
@PeterN PeterN closed this as completed in 0749a29 Feb 3, 2019
@George-VB
Copy link
Author

Fixed successfully

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression It used to work, and now it's broken.
Projects
None yet
Development

No branches or pull requests

3 participants