Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-build-vms: pass --option to nix-build #55121

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Feb 3, 2019

Motivation for this change

Also simplified the argument parsing to write all currently supported
CLI options into a bash array and pass this to nix-build.

Also documented --option usage in the corresponding manpage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also simplified the argument parsing to write all currently supported
CLI options into a bash array and pass this to `nix-build`.

Also documented `--option` usage in the corresponding manpage.
@Ma27 Ma27 force-pushed the add-option-support-to-nixos-build-vms branch from d3c0a93 to e998f51 Compare February 4, 2019 09:46
@Ma27
Copy link
Member Author

Ma27 commented Mar 7, 2019

Ping @svanderburg as you're the original author. It would be awesome if you could review this :)

Copy link
Contributor

@danbst danbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. Let's wait till someone's 👀 doublecheck this.

@Ma27
Copy link
Member Author

Ma27 commented Apr 11, 2019

@danbst is there anything that keeps us from merging? :)

@danbst
Copy link
Contributor

danbst commented Apr 13, 2019

@Ma27 I waited for some other eyes to look through this. But if you insist...

@danbst danbst merged commit eddb31b into NixOS:master Apr 13, 2019
@Ma27 Ma27 deleted the add-option-support-to-nixos-build-vms branch April 14, 2019 00:02
Ma27 added a commit to Ma27/nix-zsh-completions that referenced this pull request Apr 14, 2019
The `nixos-build-vms` script supports `--option` since
NixOS/nixpkgs#55121. Also added completions for {-h,--help}.
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Apr 18, 2019
Added new completions for `nixos-build-vms`[1].

See https://github.com/spwhitt/nix-zsh-completions/releases/tag/0.4.3

[1] NixOS#55121 added support for
`--option`.
@Ma27 Ma27 mentioned this pull request Apr 18, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants