ndppd module: refactor and fix #55122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
reviewed
Feb 3, 2019
|
the change itself seems fine, I'll test it locally just to be sure, and check if we can easily backport this as discussed with you previously. @GrahamcOfBorg test ndppd |
|
Merge/Test got delayed because of poor train wifi. I'll hope that I can finish this tonight :) |
|
As discussed yesterday, the module is actually backwards-compatible and is hence backportable. I confirmed this by building a simple NixOS VM network (as done in the test) and didn't encounter any behavioral differences after backporting the commits from this PR. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
implements more options for the ndppd module and marks the previous interface as 'soon to be removed' while keeping backward compatibility in order to keep config options closer to ndppd.conf syntax.
thanks to @fpletz for the test and the package fix :)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)