Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow AI companies to start immediately. #7151

Merged
merged 1 commit into from Feb 2, 2019

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 31, 2019

Allow multiple AIs to possibly start in the same tick.
start_date = 0 becomes a special case, where random deviation does not occur.
If start_date was not already 0, then a minimum value of 1 must apply.

Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScriptConfig::AddRandomDeviation() could be simpler, just assume "start_date" exists only for AIs, and if it's 0 then don't add random to it

src/ai/ai_gui.cpp Outdated Show resolved Hide resolved
src/ai/ai_config.cpp Outdated Show resolved Hide resolved
src/ai/ai_config.cpp Outdated Show resolved Hide resolved
@SamuXarick SamuXarick changed the title Codechange: Allow AI companies start_date to be 0 Change: Allow AI companies to start immediately. Jan 31, 2019
@SamuXarick SamuXarick force-pushed the start_date-=-0 branch 2 times, most recently from 1539a46 to 7069060 Compare February 1, 2019 14:39
src/company_cmd.cpp Outdated Show resolved Hide resolved
Allow multiple AIs to possibly start in the same tick.
start_date = 0 becomes a special case, where random deviation does not occur.
If start_date was not already 0, then a minimum value of 1 must apply.
@PeterN PeterN merged commit 011257d into OpenTTD:master Feb 2, 2019
@SamuXarick SamuXarick deleted the start_date-=-0 branch February 3, 2019 23:41
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Feb 4, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Feb 4, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Feb 4, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Feb 4, 2019
nielsmh pushed a commit that referenced this pull request Feb 5, 2019
PeterN added a commit that referenced this pull request Feb 11, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Mar 24, 2019
…tiplayer, or with shift pressed."

This reverts commit b1e40b6.

This is a fix for a patch that will be reverted in the next commit.
TrueBrain added a commit that referenced this pull request Mar 24, 2019
…r, or with shift pressed."

This reverts commit b1e40b6.

This is a fix for a patch that will be reverted in the next commit.
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants