Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage: add compatibility for sphinx 1.8.3 #55078

Merged
merged 1 commit into from Feb 2, 2019
Merged

sage: add compatibility for sphinx 1.8.3 #55078

merged 1 commit into from Feb 2, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 2, 2019

Motivation for this change

Since #48841 was replaced by
#54186, this needs to be done
separately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
sage: add compatibility for sphinx 1.8.3
2f49da3 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.
@timokau timokau merged commit 33db01e into NixOS:staging Feb 2, 2019
@timokau timokau deleted the sage-sphinx-compat branch February 2, 2019 12:02
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (NixOS#55078)
fd1079f 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (NixOS#55078)
3942e00 
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
@timokau timokau mentioned this pull request Feb 11, 2019
Merged
10 tasks
timokau added a commit that referenced this pull request Feb 11, 2019
@timokau
sage: add compatibility for sphinx 1.8.3 (#55078) (#55560)
342333c 
Since #48841 was replaced by
#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg