Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd: fix sh not in path #55073

Merged
merged 2 commits into from Feb 4, 2019
Merged

lxd: fix sh not in path #55073

merged 2 commits into from Feb 4, 2019

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Feb 2, 2019

Motivation for this change

lxd networking is broken in nixos. On initial setup with lxd init it works because when running lxd directly sh is in PATH. Running lxd network edit afterwards fails.
The problem is sh is not in PATH and lxd is not using /bin/sh as can be seen here https://github.com/lxc/lxd/blob/master/lxd/iptables.go#L97.

Things done

In this PR I add /bin/ to the PATH available for the lxd wrapper.
Added bash to makeBinPath to provide sh executable t lxd.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/admin/lxd/default.nix Outdated Show resolved Hide resolved
@markuskowa markuskowa merged commit 76c0ebc into NixOS:master Feb 4, 2019
@megheaiulian megheaiulian deleted the feature/lxd-sh-fix branch February 4, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants