Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
lxd
networking is broken in nixos. On initial setup withlxd init
it works because when running lxd directlysh
is in PATH. Runninglxd network edit
afterwards fails.The problem is
sh
is not inPATH
andlxd
is not using/bin/sh
as can be seen here https://github.com/lxc/lxd/blob/master/lxd/iptables.go#L97.Things done
In this PR I add/bin/
to the PATH available for thelxd
wrapper.Added bash to makeBinPath to provide
sh
executable t lxd.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)