Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thinkfan: add option for libatasmart support #55142

Merged
merged 1 commit into from Mar 5, 2019

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

This patch allows you to build thinkfan with SMART support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FlorianFranzen
Copy link
Contributor Author

I have been using this to keep my NAS hard drives nice and cool for a while now and it works just fine.

@infinisil and @domenkozar, is there any chance to see this merged?

@domenkozar
Copy link
Member

Why make it optional?

@FlorianFranzen
Copy link
Contributor Author

@domenkozar It adds an extra dependency and is also disabled by default by thinkfan itself. Furthermore the official readme states:

   USE_ATASMART:BOOL (default: OFF)
       Enable libatasmart to read temperatures directly from hard disks. Use
       this only when you really need it, since libatasmart is unreasonably
       CPU-intensive.

As I did not have the time to find out, if that CPU penalty is triggered by compiling in SMART support or only if also using it, I opted to make the feature optional.

@domenkozar domenkozar merged commit f60459a into NixOS:master Mar 5, 2019
@FlorianFranzen FlorianFranzen deleted the thinkfan_smart branch March 10, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants