Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nginx: support h2c #55192

Merged
merged 1 commit into from Mar 8, 2019
Merged

nixos/nginx: support h2c #55192

merged 1 commit into from Mar 8, 2019

Conversation

w4
Copy link
Contributor

@w4 w4 commented Feb 4, 2019 •
edited

Motivation for this change

haproxy 1.9 supports interfacing with backends over plain HTTP/2 (without TLS), nginx also supports this feature but the service definition forces use of TLS to enable HTTP/2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@w4 w4 requested a review from infinisil as a code owner February 4, 2019 11:12
@w4 w4 closed this Feb 22, 2019
@w4 w4 reopened this Feb 22, 2019
@infinisil
Copy link
Member

Commit message should have the nixos/nginx: prefix but otherwise this looks good :)

@w4
Copy link
Contributor Author

w4 commented Mar 8, 2019

Oops yeah sorry about that, fixed

@w4 w4 changed the title nginx: support h2c nixos/nginx: support h2c Mar 8, 2019
@infinisil infinisil merged commit eeb3733 into NixOS:master Mar 8, 2019
@dhess
Copy link
Contributor

dhess commented Mar 11, 2019

Hi, this commit breaks vhosts that serve content on port 80 and don't auto-redirect to port 443, including Let's Encrypt ACME auto-renewal. Please see #57324.

@Izorkin
Copy link
Contributor

Izorkin commented Mar 15, 2019

With this PR error worked no https sites.

@infinisil infinisil mentioned this pull request Mar 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@w4 @infinisil @dhess @Izorkin @GrahamcOfBorg @Janik-Haag