Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140 #55188

Closed
wants to merge 2 commits into from
Closed

nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140 #55188

wants to merge 2 commits into from

Conversation

shmish111
Copy link
Contributor

@shmish111 shmish111 commented Feb 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@shmish111
bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140
7dc1bea 
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on NixOS#55184
@shmish111
nixos/bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140
f70e291 
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on:
  NixOS#54996
  NixOS#55187
@shmish111 shmish111 mentioned this pull request Feb 4, 2019
Closed
10 tasks
@andir andir mentioned this pull request Feb 4, 2019
Closed
10 tasks
kalbasit
kalbasit reviewed Mar 21, 2019
View reviewed changes
pkgs/servers/bazel-remote/default.nix
@@ -0,0 +1,24 @@
{ stdenv, fetchFromGitHub, buildGoPackage }:

buildGoPackage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this duplicating #55187? Can we please merge back into #54996 but have 3 separate commits? It's difficult to review or test the PRs as it.

@uri-canva
Copy link
Contributor

bazel-remote already exists at the top level:

nixpkgs/pkgs/top-level/all-packages.nix

Line 8461 in 52dae14

bazel-remote = callPackage ../development/tools/build-managers/bazel/bazel-remote { };

You probably want to update/move the existing derivation rather than creating a new one.

@shmish111
Copy link
Contributor Author

I think this PR was created by mistake, sorry

@shmish111 shmish111 closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shmish111 @uri-canva @kalbasit @GrahamcOfBorg