Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k2pdfopt: 2.42 -> 2.51a #55150

Closed
wants to merge 2 commits into from
Closed

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Update to latest version of k2pdfopt. See https://www.willus.com/k2pdfopt/k2pdfopt_version.txt for changes.

This requires the fix from #55148 in order to build, which is also included as a commit in this branch. I sent it as a separate PR in case you'd like to merge it separately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Feb 7, 2019

Tested and rebased on top of master: 2d2f104

@fpletz fpletz closed this Feb 7, 2019
fpletz pushed a commit that referenced this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants