Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: make reproducible #55158

Merged
merged 1 commit into from Feb 4, 2019
Merged

perl: make reproducible #55158

merged 1 commit into from Feb 4, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Feb 4, 2019

Perl likes to capture impure data, needlessly.

  • Configure time (cf_time): make 1 second past epoch
  • Target system (uname): use less uname information

I built on three systems, and got the following on each:

$ nix hash-path /nix/store/5sns3d01qmxv5673k04cmiv7pmq9pkq8-perl-5.28.1
8e87786a3de293fc894e7c2582267cf5022f006dc77644d7ff8d24d3af20e8d16bdd044b0646c5294ef01415b953417c9c8deab03e7e0aeddcdf5cad588f3f99
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
perl: make reproducible
df8b672 
Perl likes to capture impure data, needlessly.

 - Configure time (cf_time): make 1 second past epoch
 - Target system (uname): use less uname information
@grahamc grahamc changed the base branch from master to staging February 4, 2019 14:10
@edolstra edolstra merged commit e3c3617 into NixOS:staging Feb 4, 2019
@grahamc grahamc deleted the reproducible-perl branch February 4, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @edolstra @GrahamcOfBorg