Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-polly,clang-polly: Add llvm/clang variants w/polly support #55065

Merged
merged 2 commits into from Feb 25, 2019
Merged

llvm-polly,clang-polly: Add llvm/clang variants w/polly support #55065

merged 2 commits into from Feb 25, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 2, 2019

Motivation for this change

Polly is much easier to use when linked into llvm and friends.

Related: #20941.

We may want to enable it by default, unsure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
llvm: build w/polly in-tree, optionally
478e673 
Don't enable by default yet, defer rebuilds.
@dtzWill
top-level: llvm-polly, clang-polly
75cbb24 
* bit hacky re:overrides
* need to explicitly set cmake flags for clang to link in polly
@dtzWill dtzWill merged commit ed60483 into NixOS:master Feb 25, 2019
@dtzWill dtzWill deleted the feature/llvm-clang-polly branch February 25, 2019 21:20
@o1lo01ol1o
Copy link

@dtzWill I'm trying to use clang and polly in a shell, but clang doesn't recognize -polly. here's a gist: https://gist.github.com/o1lo01ol1o/4cec6a9fe06bef660dd981557bd37674

Do I have the correct packages?

@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @o1lo01ol1o @Mic92 @7c6f434c @GrahamcOfBorg