Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glowing-bear: init at 0.7.1 #55132

Merged
merged 1 commit into from Feb 7, 2019
Merged

glowing-bear: init at 0.7.1 #55132

merged 1 commit into from Feb 7, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Feb 3, 2019

Motivation for this change

Glowing Bear is a web frontend for the weechat relay protocol. It's a static HTML/CSS/JS app, and does not require any build (i.e. what's in the git repo can be directly copied to your webroot and ran).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Lassulus
Lassulus approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with python -m http.server and connected successfully to my weechat session

@srhb srhb merged commit aaa2cb4 into NixOS:master Feb 7, 2019
@delroth delroth deleted the glowing-bear branch February 8, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @Lassulus @srhb @GrahamcOfBorg