-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse at signal timeouts occur unexpectedly quickly, affects title game #7159
Comments
Seems to ultimately be caused by separate things using the same counter? |
Is it caused by #7114? |
Train::wait_counter is only used for one thing in this case.
No, it is not a pathfinder issue. Reverting e934f09 is sufficient to resolve the issue. |
I was referring to the use of progress, not wait_counter. |
With the current code, a train waiting at a one-way signal will increment wait_counter twice each tick, i.e. on both Previously, the update rate of wait_counter depended on train speed and acceleration. For example train 2 from the title game (Turner Turbo) incremented wait_counter every ten ticks, while train 12 (Lev4) incremented every five ticks. The easiest change would be to the factor in the |
Apart from being twice as fast, this new behaviour also seems to match the setting description better. However I guess the comment was wrong before. Should be possible to at least not increment it on both |
…o short. This is not an exact fix as previously, the wait time was speed/acceleration dependant. This simple fix ignores that and just makes it somewhat right.
…o short. This is not an exact fix as previously, the wait time was speed/acceleration dependant. This simple fix ignores that and just makes the 'days' from the settings comment to be actually days.
…o short. This is not an exact fix as previously, the wait time was speed/acceleration dependant. This simple fix ignores that and just makes the 'days' from the settings comment to be actually days.
…o short. This is not an exact fix as previously, the wait time was speed/acceleration dependant. This simple fix ignores that and just makes the 'days' from the settings comment to be actually days.
Version of OpenTTD
master: from commit e934f09 onwards
Expected result
When _settings_game.pf.reverse_at_signals is true, reversing of trains at a red signal occurs after the interval given by _settings_game.pf.wait_oneway_signal or _settings_game.pf.wait_twoway_signal.
Actual result
When _settings_game.pf.reverse_at_signals is true, reversing of trains at a red signal occurs at a shorter interval than expected.
Steps to reproduce
Watch the title game for a few minutes, diesel trains going over the bridge at the top occasionally reverse on the bridge or in the the signal block prior to the bridge, due to moderate delays which are less than that given by _settings_game.pf.wait_oneway_signal. This did not occur prior to commit e934f09 and is probably undesirable in the title game.
The text was updated successfully, but these errors were encountered: