Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy: Update interpreter, unbreak many packages #55182

Closed
wants to merge 13 commits into from

Conversation

MostAwesomeDude
Copy link
Contributor

@MostAwesomeDude MostAwesomeDude commented Feb 4, 2019

Motivation for this change

I like PyPy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This PR updates the PyPy interpreter versions and unbreaks many packages, including the ubiquitous Numpy.

@MostAwesomeDude
Copy link
Contributor Author

@GrahamcOfBorg build pypyPackages.mock

1 similar comment
@Ekleog
Copy link
Member

Ekleog commented Feb 10, 2019

@GrahamcOfBorg build pypyPackages.mock

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2019

@GrahamcOfBorg build magic-wormhole python27Packages.magic-wormhole python27Packages.magic-wormhole-transit-relay python37Packages.magic-wormhole-transit-relay transporter

nix-repl> map (s: s.isPyPy) [ python python3 pypy pypy3 ]
[ false false true true ]
Note that this bumps both the 2.7 and 3.5 flavors of PyPy.
Not sure whether this is right TBH.
I looked at some of the failing tests and now I'm feeling rather queasy.
Calling Trial directly enables PyPy support, since our PyPy packages
only have a `pypy` binary rather than `python`.
Included a comment for the upstream commit where this was fixed
recently:
pallets/werkzeug@1cfdcf9
It Just Works now that everybody's versions have been bumped.
@FRidh
Copy link
Member

FRidh commented Apr 9, 2019

pushed to staging

@andersk
Copy link
Contributor

andersk commented Jul 7, 2019

Hydra has been failing to build pypy-7.0.0 and pypy3-7.0.0, and so has my system. Was this ever tested using sandboxing?

andersk referenced this pull request Jul 31, 2019
swiften is broken since 2018-10-18:
x86_64-linux:  https://hydra.nixos.org/build/97180305
aarch64-linux: https://hydra.nixos.org/build/97193043

pypy is broken since 2019-05-29:
x86_64-linux (pypy):  https://hydra.nixos.org/build/97214777
x86_64-linux (pypy3): https://hydra.nixos.org/build/97221287

The builds for swiften and reposurgeon (depends on pypy) regularly fail
during rebuilds for SCons updates (e.g. [0]).

[0]: #65392
@andersk
Copy link
Contributor

andersk commented Jul 31, 2019

And…now pypy is marked as broken (8760c69).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants