Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140 #55187

Closed
wants to merge 1 commit into from

Conversation

shmish111
Copy link
Contributor

@shmish111 shmish111 commented Feb 4, 2019

An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on #55184

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on NixOS#55184
shmish111 added a commit to shmish111/nixpkgs that referenced this pull request Feb 4, 2019
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.

Depends on:
  NixOS#54996
  NixOS#55187
@andir
Copy link
Member

andir commented Feb 4, 2019

Can this be closed since there is now #55188?

In general you can always update a PR by force-pushing onto the branch you used to create a PR.

@shmish111
Copy link
Contributor Author

@andir I created three separate PRs to replace #54996 at the request of @infinisil

@@ -0,0 +1,24 @@
{ stdenv, fetchFromGitHub, buildGoPackage }:

buildGoPackage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new buildGoModule instead of buildGoPackage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalbasit Can that information be included in https://nixos.org/nixpkgs/manual/#sec-language-go?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uri-canva it's already there, it's just not on the manual online as it's still version 18.09. I published the manual here, it's also described on the announcement on my blog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@uri-canva
Copy link
Contributor

uri-canva commented Mar 22, 2019

bazel-remote already exists at the top level:

bazel-remote = callPackage ../development/tools/build-managers/bazel/bazel-remote { };

You probably want to update/move the existing derivation rather than creating a new one.

@shmish111
Copy link
Contributor Author

closing as bazel-remote in nixpkgs from another PR now

@shmish111 shmish111 closed this Mar 22, 2019
@uri-canva
Copy link
Contributor

Note that the current derivation only supports Darwin, so you'll still need to update it if you want to add it for NixOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants