-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
bazel-remote: init at 57a18163783d3d0cb199ad93bcc788c864ec4140 #55187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel. Depends on NixOS#55184
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel. Depends on: NixOS#54996 NixOS#55187
Can this be closed since there is now #55188? In general you can always update a PR by force-pushing onto the branch you used to create a PR. |
@andir I created three separate PRs to replace #54996 at the request of @infinisil |
@@ -0,0 +1,24 @@ | |||
{ stdenv, fetchFromGitHub, buildGoPackage }: | |||
|
|||
buildGoPackage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the new buildGoModule
instead of buildGoPackage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalbasit Can that information be included in https://nixos.org/nixpkgs/manual/#sec-language-go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uri-canva it's already there, it's just not on the manual online as it's still version 18.09. I published the manual here, it's also described on the announcement on my blog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you!
nixpkgs/pkgs/top-level/all-packages.nix Line 8461 in 52dae14
You probably want to update/move the existing derivation rather than creating a new one. |
closing as bazel-remote in nixpkgs from another PR now |
Note that the current derivation only supports Darwin, so you'll still need to update it if you want to add it for NixOS. |
An HTTP/1.1 server that is intended to be used as a remote build cache for Bazel.
Depends on #55184
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)