Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odpic: 2.4.2 -> 3.1.0 #55204

Closed
wants to merge 1 commit into from
Closed

odpic: 2.4.2 -> 3.1.0 #55204

wants to merge 1 commit into from

Conversation

jsamsa
Copy link
Contributor

@jsamsa jsamsa commented Feb 4, 2019

Motivation for this change

Upgrade to 3.1.0 as pythonPackages.cx_oracle now depends on 3.1.0 and fails to compile with 2.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 4, 2019

Duplicate of #55049 - which is currently blocked, due to the haskellPackages.odpic-raw breaking with the API changes introduced - see the issue linked there.

@flokli flokli closed this Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsamsa @flokli @Janik-Haag