Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libffi: enable static build #55207

Closed
wants to merge 1 commit into from
Closed

libffi: enable static build #55207

wants to merge 1 commit into from

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Feb 4, 2019

Motivation for this change

Flags to have libffi produces static libraries.

This won't generate any rebuild because static libraries are not built by default in this case. I tried to copy what I observed for ncurses.

ping #43795

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [] Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@guibou guibou mentioned this pull request Feb 4, 2019
Merged
10 tasks
@matthewbauer
Copy link
Member

Does this not work out of the box? We add --enable-static and --disable-shared for everything in static.nix:

nixpkgs/pkgs/stdenv/adapters.nix

Line 56 in ca00533

makeStaticLibraries = stdenv: stdenv //

@guibou
Copy link
Contributor Author

guibou commented Feb 4, 2019 •
edited

@matthewbauer You are right. Sorry. I'm closing the PR.

@guibou guibou closed this Feb 4, 2019
@guibou guibou deleted the static_libffi branch February 4, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guibou @matthewbauer @GrahamcOfBorg