Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] buildbot: fix CVE-2019-7313 #55160

Merged
merged 1 commit into from Feb 4, 2019
Merged

[18.03] buildbot: fix CVE-2019-7313 #55160

merged 1 commit into from Feb 4, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 4, 2019

Motivation for this change

https://github.com/buildbot/buildbot/wiki/CRLF-injection-in-Buildbot-login-and-logout-redirect-code
Fix for master comes as bump to 1.8.1 #52536

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Feb 4, 2019

@GrahamcOfBorg test buildbot

@veprbl veprbl merged commit fe792ef into NixOS:release-18.03 Feb 4, 2019
@veprbl
Copy link
Member Author

veprbl commented Feb 4, 2019

buildbot failed on Hydra after new evaluation: https://hydra.nixos.org/eval/1503570
I can't reproduce it locally and it was fine on OfBorg before I merged.

@veprbl veprbl deleted the pr/buildbot_CVE-2019-7313_18.03 branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @GrahamcOfBorg