Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem options: fix use of deprecated mkOption { options = ...; } #1088

Merged
merged 1 commit into from Feb 5, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Feb 3, 2019

NixOS/nixpkgs@27982b4 removed it,
breaking nixops in the process. Migrate to the new recommended way of
enriching options.

Fixes #1086.

NixOS/nixpkgs@27982b4 removed it,
breaking nixops in the process. Migrate to the new recommended way of
enriching options.

Fixes NixOS#1086.
@teto
Copy link
Member

teto commented Feb 5, 2019

solved it for me thanks \o/

@AmineChikhaoui AmineChikhaoui merged commit 8ed39f9 into NixOS:master Feb 5, 2019
@AmineChikhaoui
Copy link
Member

thanks !

erictapen added a commit to erictapen/nixpkgs that referenced this pull request Feb 6, 2019
This fixes evaluation with the latest master. See also [0] and [1] for
this.

[0] NixOS/nixops#1086
[1] NixOS/nixops#1088
worldofpeace pushed a commit to NixOS/nixpkgs that referenced this pull request Feb 6, 2019
This fixes evaluation with the latest master. See also [0] and [1] for
this.

[0] NixOS/nixops#1086
[1] NixOS/nixops#1088
@delroth
Copy link
Contributor Author

delroth commented Mar 3, 2019

@AmineChikhaoui any thoughts to making a 1.6.2 (or 1.6.1.1 :) ) release with this included? 19.03 is coming very soon and nixops is currently unusable in it (19.03 packages 1.6.1, latest stable, but 1.6.1 doesn't work with 19.03). I've seen plenty of confusion on nixpkgs, #nixos, even #1086 on this repo.

@danbst
Copy link
Contributor

danbst commented Mar 5, 2019

@delroth I'm reverting my change, as it turned out to cause more harm than good.

@AmineChikhaoui
Copy link
Member

@delroth Yes, I'm running the tests now and I'll then ask Rob to add a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants