nix1: fix perl-bindings build
#55146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
added a commit
to lopsided98/nixpkgs
that referenced
this pull request
Feb 4, 2019
The component `hydra-evaluator` requires `pool.hh` from Nix which isn't
provided by Nix 1.x and thus fails with the following error in this
case:
```
hydra-evaluator.cc:3:10: fatal error: pool.hh: No such file or directory
#include "pool.hh"
^~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:443: hydra_evaluator-hydra-evaluator.o] Error 1
```
As the commit is from 2016 and fairly hard to revert for Nix 1.x
support, it's easier to drop that.
This has been tested with fixed perl-bindings for Nix1 as done in NixOS#55146.
alyssais
requested changes
Feb 7, 2019
Ma27
force-pushed
the
fix-nix1-perl-bindings
branch
from
0eafc98
to
a772d19
Compare
alyssais
reviewed
Feb 8, 2019
Nix 1.11 builds perl-bindings by default, `nix1.perl-bindings` fails with the following error: ``` building no Makefile, doing nothing installing install flags: install make: *** No rule to make target 'install'. Stop. ``` This is probably due to NixOS#47316. Previously the `perl-bindings` were referenced to `nix1` instead of the `perl-bindings` function as Nix 1.11 built those during its build process.
Ma27
force-pushed
the
fix-nix1-perl-bindings
branch
from
a772d19
to
8092ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Nix 1.11 builds perl-bindings by default,
nix1.perl-bindingsfailswith the following error:
This is probably due to #47316. Previously the
perl-bindingswerereferenced to
nix1instead of theperl-bindingsfunction as Nix 1.11built those during its build process.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)