Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

programs.ssh.knownHosts: update example to be an attrset #54273

Merged
merged 1 commit into from Jan 21, 2019
Merged

programs.ssh.knownHosts: update example to be an attrset #54273

merged 1 commit into from Jan 21, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 18, 2019

We shouldn't encourage using a list here, but prefer the attrset.
Using a list here causes very unintuitive effects during merging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
programs.ssh.knownHosts: update example to be an attrset
4f11c06 
We shouldn't encourage using a list here, but prefer the attrset.
Using a list here causes very unintuitive effects during merging.
@flokli flokli requested a review from Mic92 January 18, 2019 14:42
@arianvp
Copy link
Member

arianvp commented Jan 21, 2019

Didn't we deprecate the use of loaOf ?

Can't we replace the type of it for 19.03?

@flokli
Copy link
Contributor Author

flokli commented Jan 21, 2019

@arianvp There's #1800 from @shlevy

@flokli flokli merged commit 0b4db9f into NixOS:master Jan 21, 2019
@flokli flokli deleted the ssh-known-hosts-example branch January 21, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @arianvp @Mic92 @GrahamcOfBorg