Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-manager: 0.7.3.1 -> 0.7.4.1 #54272

Merged
merged 2 commits into from Jan 26, 2019
Merged

Conversation

wedens
Copy link

@wedens wedens commented Jan 18, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

Quiet weird to see travis here.

@worldofpeace
Copy link
Contributor

@wedens Can you also switch to using the meson build system?

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

@GrahamcOfBorg build font-manager

@wedens
Copy link
Author

wedens commented Jan 19, 2019

@worldofpeace I've never used meson before.

I've tried using meson, but I've got some errors/warnings:

lib/unicode/meson.build:23: WARNING: Passed invalid keyword argument "copy".
WARNING: This will become a hard error in the future.
lib/unicode/meson.build:23:0: ERROR:  Configure_file must have either "configuration" or "command".
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

@worldofpeace
Copy link
Contributor

@worldofpeace I've never used meson before.

I've tried using meson, but I've got some errors/warnings:

lib/unicode/meson.build:23: WARNING: Passed invalid keyword argument "copy".
WARNING: This will become a hard error in the future.
lib/unicode/meson.build:23:0: ERROR:  Configure_file must have either "configuration" or "command".
WARNING: Unknown command line options: "auto_features"
This will become a hard error in a future Meson release.

I couldn't reproduce. I've made these changes in baa4b0c

@jtojnar
Copy link
Contributor

jtojnar commented Jan 20, 2019

That error looks like you were using old meson.

@infinisil infinisil merged commit 0a7791b into NixOS:master Jan 26, 2019
@wedens wedens deleted the font-maanger-bump branch January 28, 2019 14:17
@wedens
Copy link
Author

wedens commented Jan 28, 2019

Seems like meson build introduced this problem when font-manager is installed with file-roller:

collision between `/nix/store/nds8x5h7i4v08618hyzi9pmk0knmsm23-font-manager-0.7.4.1/share/applications/mimeinfo.cache' and `/nix/store/vmrdln2j9pwkxmv4yw5b3xi0h8lfa1s3-file-roller-3.28.1/share/applications/mimeinfo.cache'

I suspect this file is why it doesn't happen with make.

@worldofpeace
Copy link
Contributor

Seems like meson build introduced this problem when font-manager is installed with file-roller:

collision between `/nix/store/nds8x5h7i4v08618hyzi9pmk0knmsm23-font-manager-0.7.4.1/share/applications/mimeinfo.cache' and `/nix/store/vmrdln2j9pwkxmv4yw5b3xi0h8lfa1s3-file-roller-3.28.1/share/applications/mimeinfo.cache'

I suspect this file is why it doesn't happen with make.

Yeah I think that's a known issue. We probably need a setup hook to remove these mimeinfo.cache.

@wedens wedens mentioned this pull request Jan 31, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants