Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.alcotest: 0.8.2 -> 0.8.5 #54282

Merged
merged 1 commit into from Jun 4, 2019
Merged

ocamlPackages.alcotest: 0.8.2 -> 0.8.5 #54282

merged 1 commit into from Jun 4, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 18, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019 

@GrahamcOfBorg build ocamlPackages.alcotest ocamlPackages.angstrom ocamlPackages.bigstringaf ocamlPackages.checkseum ocamlPackages.email_message ocamlPackages.faraday ocamlPackages.farfadet ocamlPackages.git ocamlPackages.git-http ocamlPackages.git-unix ocamlPackages.httpaf ocamlPackages.ppx_blob ocamlPackages.stog trv

@vbgl
Copy link
Contributor Author

vbgl commented Jan 27, 2019

@Mic92 Do you understand the build failures on darwin and aarch64? Are they related to this change?

@vbgl
Copy link
Contributor Author

vbgl commented Mar 3, 2019

@GrahamcOfBorg build stog trv

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019

@GrahamcOfBorg build stog trv

@vbgl vbgl merged commit 9120dbf into NixOS:master Jun 4, 2019
@vbgl vbgl deleted the ocaml-alcotest-0.8.5 branch June 4, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg