Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybase 2.13.1 #54277

Merged
merged 3 commits into from Jan 21, 2019
Merged

Keybase 2.13.1 #54277

merged 3 commits into from Jan 21, 2019

Conversation

emmanuelrosa
Copy link
Contributor

@emmanuelrosa emmanuelrosa commented Jan 18, 2019 •
edited

Motivation for this change

This change updates the keybase clients to version 2.13.1

This update introduces a Stellar (XLM) wallet built-in to the GUI client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
      - [] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • /nix/store/crmrla0ldzwq9xxi7sk95mpyq20n3xc2-keybase-gui-2.13.0 514194056
    • /nix/store/agy45qxjhd1599rvw04j0lf068y9cbqw-keybase-gui-2.13.1 602877480
    • /nix/store/7f052pbid2v2sr0wkpi1x8fpjxyiavmk-keybase-2.11.0-bin 83144176
    • /nix/store/95kli1cw668417w6ff4mck35jgr6dx23-keybase-2.13.1-bin 84715536

- [ ] Assured whether relevant documentation is up to date

@worldofpeace
Copy link
Contributor

cc @rvolosatovs @kalbasit

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build keybase keybase-gui

@hedning
Copy link
Contributor

hedning commented Jan 20, 2019

The darwin build complains about wrong hash.

@emmanuelrosa
Copy link
Contributor Author

Hmm... there is the hash for the Darwin build supposed to go? I only see one hash in the package.

@kalbasit kalbasit self-requested a review January 20, 2019 23:30
@kalbasit
Copy link
Member

It's interesting that the build hash failed on Mac for the same archive. Let's try again.

@GrahamcOfBorg build keybase keybase-gui

@kalbasit
keybase: switch to fetchurl for sha256 consistency on Darwin
aba3d8c 
fetchFromGitHub and thus fetchzip hashes the contents of the archive and
not the archive itself. Unicode file names lead to different checksums
on HFS+ vs. other file systems because of Unicode normalisation
@kalbasit
Copy link
Member

@GrahamcOfBorg build keybase keybase-gui

@kalbasit kalbasit merged commit f466c9f into NixOS:master Jan 21, 2019
@emmanuelrosa emmanuelrosa deleted the keybase-2.13.1 branch January 21, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emmanuelrosa @worldofpeace @hedning @kalbasit @GrahamcOfBorg