Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/file-roller: init #54284

Merged
merged 1 commit into from Jan 19, 2019
Merged

nixos/file-roller: init #54284

merged 1 commit into from Jan 19, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Saw that file-roller has dbus services so I thought that justified a NixOS module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @hedning @jtojnar

@hedning
Copy link
Contributor

hedning commented Jan 19, 2019

Looks good to me. We should almost have an utility which makes these dbus modules.

@jtojnar
Copy link
Contributor

jtojnar commented Jan 19, 2019

Yeah, especially since everything is D-Bus activatable these days.

I am slightly confused by the fact that some D-Bus services seem to work even when only in environment.systemPackages (e.g. dconf). Anyone knows why?

@hedning
Copy link
Contributor

hedning commented Jan 19, 2019

I am slightly confused by the fact that some D-Bus services seem to work even when only in environment.systemPackages (e.g. dconf). Anyone knows why?

Right, I wondered the same thing when I noticed that gnome didn't put it into dbus.packages. Might be that dconf is able to activate it's own service, and is launched through PATH at some point?

@jtojnar
Copy link
Contributor

jtojnar commented Jan 19, 2019

By the way File Roller is another app expected to bite the dust: https://mail.gnome.org/archives/desktop-devel-list/2019-January/msg00028.html

I guess we should ask for the features we want in Nautilus, e.g. https://gitlab.gnome.org/GNOME/nautilus/issues/840

@jtojnar jtojnar merged commit 8824dde into NixOS:master Jan 19, 2019
@worldofpeace worldofpeace deleted the file-roller-module branch January 19, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @hedning @jtojnar @GrahamcOfBorg