Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] youtube-dl: 2019.01.16 -> 2019.01.17 #54276

Merged
merged 1 commit into from Jan 18, 2019
Merged

[18.09] youtube-dl: 2019.01.16 -> 2019.01.17 #54276

merged 1 commit into from Jan 18, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 18, 2019

Motivation for this change

Backport of #54275.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
youtube-dl: 2019.01.16 -> 2019.01.17
8da2083 
Fixes an issue with youtube, see
ytdl-org/youtube-dl#18891

(cherry picked from commit a1169af)
@dotlambda dotlambda added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 18, 2019
@timokau timokau changed the title youtube-dl: 2019.01.16 -> 2019.01.17 [18.09] youtube-dl: 2019.01.16 -> 2019.01.17 Jan 18, 2019
@dotlambda dotlambda merged commit 69c050c into NixOS:release-18.09 Jan 18, 2019
@timokau timokau deleted the youtube-dl-fix-18.09 branch January 18, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phreedom Phreedom Awaiting requested review from Phreedom

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@fpletz fpletz Awaiting requested review from fpletz

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@bluescreen303 bluescreen303 Awaiting requested review from bluescreen303

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg