Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk: 8u191 -> 8u201, 8u202 [Security fixes] #54269

Merged
merged 2 commits into from Jan 20, 2019
Merged

oraclejdk: 8u191 -> 8u201, 8u202 [Security fixes] #54269

merged 2 commits into from Jan 20, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 18, 2019

Motivation for this change

Security fixes and other updates.

https://www.oracle.com/technetwork/java/javase/8u201-relnotes-5209271.html
https://www.oracle.com/technetwork/java/javase/8u202-relnotes-5209339.html
https://www.oracle.com/technetwork/security-advisory/cpujan2019-5072801.html#AppendixJAVA

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested only x86_64.

pSub
pSub requested changes Jan 19, 2019
View reviewed changes
Copy link
Member

@pSub pSub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to change the build Version in jdk8cpu-linux.nix to 202 as well.

@taku0
Copy link
Contributor Author

taku0 commented Jan 20, 2019

@pSub 8u201 is a CPU, which contains only security updates, and 8u202 is a PSU, which contains CPU + other updates. They have different version numbers.

@taku0
Copy link
Contributor Author

taku0 commented Jan 20, 2019

cc: @volth, @Mic92

@Mic92 Mic92 merged commit 5ba532f into NixOS:master Jan 20, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 20, 2019

[detached HEAD c983626] oraclejdk: 8u191 -> 8u201, 8u202
Author: taku0 mxxouy6x3m_github@tatapa.org
Date: Fri Jan 18 21:28:24 2019 +0900
2 files changed, 7 insertions(+), 7 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @Mic92 @pSub @GrahamcOfBorg